Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2142] More documentation #137

Merged
merged 2 commits into from
Dec 9, 2024
Merged

[2142] More documentation #137

merged 2 commits into from
Dec 9, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 9, 2024 •
edited
Loading

Context

Improve documentation

Changes proposed in this pull request

  • Fix tfdocs links in READMEs
  • Add to DNS modules READMEs
  • Remove unused data source

Guidance to review

  • Review documentation
  • Verify data source is not used (can use tflint)

Checklist

  • I have performed a self-review of my code, including formatting and typos
  • I have cleaned the commit history
  • I have added the Devops label
  • I have attached the pull request to the trello card

@saliceti
Documentation improvements
3bd3f47 
- Fix tfdocs links
- Front door query example
- DNS Readmes
@saliceti
Remove unused DNS record data source
b698df7
@saliceti saliceti force-pushed the 2142-updated-dfe-analytics-readme-2 branch from 18d1f04 to b698df7 Compare December 9, 2024 15:28
@saliceti
Copy link
Member Author

saliceti commented Dec 9, 2024

CCBL: migrate to GCP WIF

@saliceti saliceti merged commit c53aa61 into main Dec 9, 2024
3 checks passed
@saliceti saliceti deleted the 2142-updated-dfe-analytics-readme-2 branch December 9, 2024 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RMcVelia RMcVelia RMcVelia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saliceti @RMcVelia